This repository was archived by the owner on Dec 1, 2022. It is now read-only.
permit non-String args for title and body args #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way, we can pass numbers, Dates (as numbers), and booleans. Other values should be invalid, but are not checked statically
added 2 commits
March 2, 2017 15:02
Conflicts: .gitignore LICENSE
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There needs to be a way to send non-Strings to client. This is especially important with Dates, which cannot be formatted on Server, as the server doesn't know the client device's locale. American formatted dates on other locales will look awful, especially in RTL languages.
Numbers are also important, some cultures group numbers differently, and use different symbols for decimal and grouping symbols.
With my change, you can send Arrays.asList({"asbc",new Date().getTime(), 1251212.0}), and the client firebase will automatically read the object as String, Long and double. The number can also be formatted as a date:
(from java.util.Formatter code)
```
if (arg instanceof Long) {
date = new Date(((Long) arg).longValue());
}