Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look at the current reviewRef when submitting #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Look at the current reviewRef when submitting #113

wants to merge 1 commit into from

Commits on Jul 20, 2022

  1. Look at the current reviewRef when submitting 

    When a review has been rebased and then force pushed to update a review,
for example to fix review comments. It can become impossible to submit
with the error message:

Refusing to submit a non-fast-forward review. First merge the target
ref.

this even if the review ref is a ancestor of the target ref and the
merge should been a fast forward merge. This is because the check for
appraise submit is done against the first commit sha1 that was used and
not for the actually reviewRef that will be merged. This fixes that.
    @iveqy
    iveqy committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    047bb24 View commit details
    Browse the repository at this point in the history