-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add Credentials Revoke API #3847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
8d3e65f to
b2b08fa
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3847 +/- ##
=======================================
Coverage 92.42% 92.43%
=======================================
Files 197 198 +1
Lines 14167 14175 +8
=======================================
+ Hits 13094 13102 +8
Misses 884 884
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
refs #3846 |
gmlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @cointem!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
|
Thank you, @alexandear! |
Fixes: #3846.
This pull request introduces a new service for managing credentials in the GitHub API client, specifically adding support for revoking credentials via the API. The changes include a new service implementation, comprehensive unit tests, and integration of the service into the main client.
New Credentials Service Integration:
CredentialsServiceto the client, allowing users to revoke a list of credentials (tokens) through the newRevokemethod ingithub/credentials.go.CredentialsServicein theClientstruct and initialized it in the client setup, ensuring it is available for use. [1] [2]Testing Improvements:
TestCredentialsService_Revokeingithub/credentials_test.goto verify correct request formation, response handling, and error cases for credential revocation.