Miscellaneous bsdbpf fixes and improvements #1091
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta() to write data, SeeSent configurable option to turn on/off returning local packets. Fixes BPFSniffer creation with bpf device name provided over config options and also fixes fd leak in the case of any subsequent error during BPFSniffer instance creation.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Doridian
reviewed
Jul 23, 2023
Doridian
reviewed
Jul 23, 2023
Co-authored-by: Mark Dietzer <[email protected]>
Co-authored-by: Mark Dietzer <[email protected]>
|
@Doridian, I applied your suggestions. Thank you for the review! |
|
@Doridian can you please accept CLA to get a chance to get this merged at some point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to more or less unify afpacket and bsdbpf the following new methods will be added to BPFSniffer:
The new configurable option
SeeSentwill be added, it allows to turn on/off returning local packets over filter.There is also several fixes:
This PR also fixes #1053 and makes obsolete #1054