Improve exception handling in cache.asMap().computeIfAbsent etc.
#7980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_805040984
branch
from
b148b8d to
ec504cc
Compare
copybara-service
bot
changed the title
computeIfAbsent etc.cache.asMap().computeIfAbsent etc.
copybara-service
bot
force-pushed
the
test_805040984
branch
3 times, most recently
from
a54e525 to
2e8ddce
Compare
Don't store an exception thrown by the compute function. It doesn't appear that the stored exception is ever used. Tests still pass after this deletion. Also move the evaluation of the compute function to before the possible creation of a new entry, so if it throws an exception then no entry is created. Fixes #5438, fixes #7625, fixes #7975. RELNOTES=Handling of exceptions from compute functions in `Cache.asMap().computeIfAbsent` and the like has been improved. (We do still recommend using Caffeine rather than `com.google.common.cache`.) PiperOrigin-RevId: 805944057
copybara-service
bot
force-pushed
the
test_805040984
branch
from
2e8ddce to
087f2c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve exception handling in
cache.asMap().computeIfAbsentetc.Don't store an exception thrown by the compute function. It doesn't appear that the stored exception is ever used. Tests still pass after this deletion.
Also move the evaluation of the compute function to before the possible creation of a new entry, so if it throws an exception then no entry is created.
Fixes #5438, fixes #7625, fixes #7975.
RELNOTES=Handling of exceptions from compute functions in
Cache.asMap().computeIfAbsentand the like has been improved. (We do still recommend using Caffeine rather thancom.google.common.cache.)