gofer: Invalidate dentry if file type changes but inode number doesn't. #12153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
For some filesystems like ext4, it possible that the inode number is re-used in between unlink and file creation. Hence it is possible a file is replaced on the host filesystem with another file but the inode number remains the same. The gofer client can't detect such changes and trigger invalidation. But at least we can detect if the file type has changed and invalidate the old file. PiperOrigin-RevId: 809831715
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gofer: Invalidate dentry if file type changes but inode number doesn't.
For some filesystems like ext4, it possible that the inode number is re-used in
between unlink and file creation. Hence it is possible a file is replaced on
the host filesystem with another file but the inode number remains the same.
The gofer client can't detect such changes and trigger invalidation. But at
least we can detect if the file type has changed and invalidate the old file.