This repository was archived by the owner on Jun 12, 2024. It is now read-only.
Mostly Speed up #116
Open
Mostly Speed up #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the fix. I got an confirmation that it is ok. |
|
Our lawyers won't let me merge the other person's change, even a single-line change, unless they also accept the CLA. I'm sorry; it is annoying. Maybe it's best if you tell me about that change and I write the one line. |
|
The method |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET.
I got by email some fix to this code that I added in my repo in a commit. The change is one line. I'm contacting the author of that fix.
If I don't get an answer, I think that I could tell you which method it is and you could try to fix it?
fix gh-99