Tests for LocalMediaRepository #329
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fill out the MediaRepository interface
Apply Spotless
yasith
force-pushed
the
yasith/localMediaRepository
branch
from
fc81f5b to
83747b1
Compare
yasith
force-pushed
the
yasith/localMediaRepository
branch
from
1548bb2 to
b1b91af
Compare
Kimblebee
reviewed
Mar 19, 2025
| @IODispatcher private val iODispatcher: CoroutineDispatcher | ||
| ) : MediaRepository { | ||
|
|
||
| override suspend fun load(mediaDescriptor: MediaDescriptor): Media { |
There was a problem hiding this comment.
nit: i think it would be helpful for fresh eyes down the road to include some kdocs that describe the significance between what load() and getLastCapturedMedia() are doing.
Comment on lines
+69
to
+78
| val loadedBitmap = if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) { | ||
| // Android 10 (API 29) and above: Use ImageDecoder | ||
| context.contentResolver.openInputStream(uri)?.use { inputStream -> | ||
| BitmapFactory.decodeStream(inputStream) | ||
| } | ||
| } else { | ||
| // Android 9 (API 28) and below: Use BitmapFactory | ||
| context.contentResolver.openInputStream(uri)?.use { inputStream -> | ||
| BitmapFactory.decodeStream(inputStream) | ||
| } |
There was a problem hiding this comment.
you are using BitmapFactory for both of these cases
| * limitations under the License. | ||
| */ | ||
|
|
||
| package media |
yasith
force-pushed
the
yasith/localMediaRepository
branch
2 times, most recently
from
46c712e to
8b2632c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply Spotless