Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve anchors after parsing YAML #1163

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 1, 2024

rapidyaml seems to choke on trees which contain anchors (or perhaps, strictly, references to them) when returning JSON.

To avoid this aggressively resolve anchors/references when parsing YAML into JSON and then into our own model.

Fixes #1162


Prior to this patch, the test fails as reported in #1162 , with the fix it passes. I'm not sure if there is any perf penalty here or tbh if this is the canonical fix, but it seems to resolve the issue.

I have signed the personal contributor license agreement many years ago.

rapidyaml seems to choke on trees which contain anchors (or perhaps,
strictly, references to them) when returning JSON.

To avoid this aggressively resolve anchors/references when parsing YAML
into JSON and then into our own model.
Copy link

google-cla bot commented Aug 1, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ghost
Copy link
Author

ghost commented Aug 1, 2024

Well i guess the CLA might be an issue; closing.

However, I the author of this work, grant anyone reading it a full license under Apachee 2.0 terms to reproduce it and contribute it to this project for the purposes of resolving the linked issue.

@ghost ghost closed this Aug 1, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR: no anchor processing for JSON when using std.parseYaml from python
0 participants