Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binary search for setMember() #1190

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −2
Draft

binary search for setMember() #1190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions stdlib/std.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1470,8 +1470,20 @@ limitations under the License.
std.uniq(std.sort(arr, keyF), keyF),

setMember(x, arr, keyF=id)::
// TODO(dcunnin): Binary chop for O(log n) complexity
std.length(std.setInter([x], arr, keyF)) > 0,
local xk = keyF(x);
local binarySearch(i, j) =
if i > j then
false
else
local m = i + ((j - i) >> 1);
local mk = keyF(arr[m]);
if mk < xk then
binarySearch(m + 1, j)
else if mk > xk then
binarySearch(i, m - 1)
else
true;
binarySearch(0, std.length(arr) - 1),

setUnion(a, b, keyF=id)::
// NOTE: order matters, values in `a` win
Expand Down