activate: download arm64 Linux versions of binaries #425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroettger
reviewed
Sep 12, 2025
| @@ -31,6 +31,19 @@ if [[ "$OSTYPE" =~ ^darwin.* ]]; then | |||
| fi | |||
| export KCTF_CTF_DIR="$(realpath "$(dirname "${script_dir}")")" | |||
| unset script_dir | |||
| elif [[ "$HOSTTYPE" =~ ^aarch64.* ]]; then | |||
There was a problem hiding this comment.
Can you add a log warning somewhere that aarch64 is not fully supported (with what you mentioned in the pull request)?
Otherwise lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect arm64 Linux and download jq, kind, and kubectl for arm64.
Per #378, this isn't enough for full arm64 support (the containers would also need to be rebuilt), but this is at least useful for running kctf while using qemu-user emulation for the containers.