Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add visibility check in ResolverAAImpl.overrides #2295

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Add visibility check in ResolverAAImpl.overrides #2295

merged 1 commit into from
Jan 16, 2025

Conversation

ting-yuan
Copy link
Collaborator

override cannot happen without visibility.

fixes #2254

@jsjeon
Copy link
Member

jsjeon commented Jan 16, 2025

Those PackagePrivate(Base) classes are public, not really package private. Just to double-check if those don't matter (i.e., naming issue).

@ting-yuan
Copy link
Collaborator Author

Those PackagePrivate(Base) classes are public, not really package private. Just to double-check if those don't matter (i.e., naming issue).

Updated naming of those classes for clarity. Thanks!

@ting-yuan
Add visibility check in ResolverAAImpl.overrides
a741797 
override cannot happen without visibility.
@ting-yuan ting-yuan merged commit cccb2c6 into google:main Jan 16, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dx404 dx404 dx404 approved these changes

@jsjeon jsjeon Awaiting requested review from jsjeon

@jvgogh jvgogh Awaiting requested review from jvgogh

@mkmuir0 mkmuir0 Awaiting requested review from mkmuir0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[KSP2] Resolver#overrides() gives incorrect result when method isn't accessible.
3 participants
@ting-yuan @jsjeon @dx404