Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide pkg-config file #2631

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Provide pkg-config file #2631

wants to merge 2 commits into from

Conversation

tintou
Copy link

@tintou tintou commented Jun 15, 2021

This allows to use the pkg-config mechanism on supported systems.

@google-cla
Copy link

google-cla bot commented Jun 15, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no For Google internal commits only label Jun 15, 2021
@google-cla google-cla bot added cla: yes For CLA bot and removed cla: no For Google internal commits only labels Jun 15, 2021
@tintou
Copy link
Author

tintou commented Jun 25, 2021

@googlebot I signed it!

Copy link

@Losergfsfyjg Losergfsfyjg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete

@tintou tintou requested a review from a team as a code owner September 2, 2024 09:31
@tintou tintou force-pushed the master branch 2 times, most recently from 73fb066 to 029e16b Compare September 17, 2024 07:35
@tintou
Copy link
Author

tintou commented Sep 17, 2024

@mandlil Hi there, do you have a bit of time to review this PR?

This allows to use the pkg-config mechanism on supported systems.
@mandlil
Copy link
Contributor

mandlil commented Nov 27, 2024

Hi there, thank you for your PR. We are apologize for late reply. Currently we don't have anyone in the team to review such C++ changes. Please note our contribution guidelines, where we are committing to review and accept PRs for documentation changes and bug fixes, but due to lack of staffing, we cannot promise anything else. See
our contribution guidelines:
https://github.com/google/libphonenumber/blob/master/CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes For CLA bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants