Revert "updated to three.js r151 (#4186)" #4191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 640b554.
|
Nevermind, figured it out: #4192. |
JL-Vidinoti
pushed a commit
to vidinoti/model-viewer
that referenced
this pull request
Apr 22, 2024
This reverts commit 640b554.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 640b554.
Okay, apparently I need to tighten up my testing because this broke nearly every usage, which is to stay anything using our default or "legacy" lighting, though it's fine with a supplied HDR (like our front page astronaut). You can see the problem here:
The problem appears to be that our generated lighting is wildly blown out, causing the renders to be highly overexposed. My best guess is that because our lighting scene contains a bunch of bright emissive objects to act as lights, and these never illuminated the room itself before, but they seem to be now.
FYI @mrdoob I don't see anything in the release notes that points me to where this changed. I think I'll be asking for a point release next week, but I'm almost done for the day and I don't have any kind of solution yet. Let's pick it up Monday.