Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update VB for max code length #247

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update VB for max code length #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion visualbasic/OpenLocationCode.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ Private Const LATITUDE_MAX_ As Double = 90
' The maximum value for longitude in degrees.
Private Const LONGITUDE_MAX_ As Double = 180

' The max number of digits to process in a plus code.
Private Const MAX_DIGIT_COUNT_ As Integer = 15

' Maximum code length using lat/lng pair encoding. The area of such a
' code is approximately 13x13 meters (at the equator), and should be suitable
' for identifying buildings. This excludes prefix and separator characters.
Expand Down Expand Up @@ -211,6 +214,9 @@ Public Function OLCEncode(ByVal latitude As Double, ByVal longitude As Double, O
If codeLength < 2 Then
Err.raise vbObjectError + 513, "OLCEncodeWithLength", "Invalid code length"
End If
If codeLength > MAX_DIGIT_COUNT_ Then
codeLength = MAX_DIGIT_COUNT_
End If
Dim lat, lng As Double
Dim latCode, lngCode, gridCode As String
Dim code As String
Expand Down Expand Up @@ -264,7 +270,7 @@ Public Function OLCDecode(ByVal code As String) As OLCArea
' If there is a grid refinement component, decode that.
If Len(c) > PAIR_CODE_LENGTH_ Then
Dim gridArea As OLCArea
gridArea = decodeGrid(Mid(c, PAIR_CODE_LENGTH_ + 1))
gridArea = decodeGrid(Mid(c, PAIR_CODE_LENGTH_ + 2, MAX_DIGIT_COUNT_ - PAIR_CODE_LENGTH_))
codeArea.LatHi = codeArea.LatLo + gridArea.LatHi
codeArea.LngHi = codeArea.LngLo + gridArea.LngHi
codeArea.LatLo = codeArea.LatLo + gridArea.LatLo
Expand Down