Skip to content

Commit

Permalink
Add memory_kind to the PositionalShardingMetadata in `test_convert_…
Browse files Browse the repository at this point in the history
…between_jax_positional_sharding_and_sharding_metadata` test

PiperOrigin-RevId: 660548319
  • Loading branch information
yashk2810 authored and Orbax Authors committed Aug 7, 2024
1 parent 65416bb commit a301fc8
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion checkpoint/orbax/checkpoint/metadata/sharding_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ def test_convert_between_jax_positional_sharding_and_sharding_metadata(
[1, -1]
)
expected_positional_sharding_metadata = (
sharding_metadata.PositionalShardingMetadata(jax_sharding.shape)
sharding_metadata.PositionalShardingMetadata(
jax_sharding.shape, jax_sharding.memory_kind
)
)
converted_positional_sharding_metadata = (
sharding_metadata.from_jax_sharding(jax_sharding)
Expand Down

0 comments on commit a301fc8

Please sign in to comment.