Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSS-Fuzz maintainers - can you PTAL?
Trustworthiness of this request:
unsafe
inpng
andfdeflate
crates, although there is someunsafe
in other dependencies). This argues that most issues discovered by fuzzing should not be security issues, merely correctness/functional issues (or at most Denial-of-Service issues when a timeout happens for some inputs).png
project as a Chromium Security engineer, so I can hopefully claim some of the trust/karma that may be attributed to the Chromium Security team.Motivation for this request:
image-png
fuzzers (see fuzzer changes underneath Support for resuming decoding afterUnexpectedEof
. image-rs/image-png#496) and fixed a few resulting failures found by OSS-Fuzz (e.g. Fix resumingnext_frame
afterUnexpectedEof
(APNG trouble). image-rs/image-png#498, Avoid infinite loops inbuf_independent
fuzzer after real EOF. image-rs/image-png#499, or Restore usingNoMoreImageData
errors. image-rs/image-png#500). I would like to monitor OSS-Fuzz for additional failures (if any) and help with investigating and/or fixing them.image-png
fuzzer that I have trouble repro-ing: https://oss-fuzz.com/testcase-detail/5146320858316800. I hope that getting access to the full fuzzing corpus will help me repro this in a different way locally.Disclaimer: in the long-term the ownership of
png
/ Skia / Chromium integration may shift, but I think it still makes sense to add me for now/cc @fintelia