sound-open-firmware: restore build, semantic fix and enable UBSAN #12607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cujomalainey is either the primary contact or is in the CCs list of projects/sound-open-firmware. |
andyross
approved these changes
Oct 16, 2024
|
|
||
| git clone --filter=tree:0 https://github.com/zephyrproject-rtos/sdk-ng | ||
| RELEASES=$(curl -L -H "Accept: application/vnd.github+json" -H "X-GitHub-Api-Version: 2022-11-28" https://api.github.com/repos/zephyrproject-rtos/sdk-ng/releases) | ||
| SDK=$(jq '[.[] | select(.prerelease == false) | {tag: .tag_name, assets: .assets[] | select(.name | contains("linux-x86_64_minimal.tar.xz"))}] | .[0]' <<< $RELEASES) |
There was a problem hiding this comment.
This is much cleaner than the original for sure. My facility with github API hacking and jq are both at the "well, I know those tools exist" level.
|
im going to drop the arch 64 build since it appears to be causing problems. |
Fetching via tag can sometimes leave us in a state where the release has been created but the actual assets have not been published. It also means that we are using pre-releases which is not always desirable. Using the Github API for a lookup resolves this issue.
Borrow some snippets from the connectedhomeip project and pull in python3.10 to satisfy zephyr constraints.
use $SRC over /src
Signed-off-by: Curtis Malainey <[email protected]>
Future work to enable 64 bit builds
|
Fixed the coverage build by landing a config change in the source repo, this should be good to go now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.