Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KImageFormats: JXR library modified with a patched one #12702

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

mircomir
Copy link
Contributor

@mircomir mircomir commented Nov 9, 2024

The previous version does not accept changes and is compiled by default without the NDEBUG option.

@mircomir
Copy link
Contributor Author

mircomir commented Nov 9, 2024

@tsdgeos

Copy link

github-actions bot commented Nov 9, 2024

mircomir has previously contributed to projects/kimageformats. The previous PR was #12690

@tsdgeos
Copy link
Contributor

tsdgeos commented Nov 10, 2024

I'm not sure this is a good idea unless we can somehow convince the world to switch to use your fork and not the upstream one...

...oh i see there's no upstream one?

Should we try to convince Linux distributions to switch to your repository?

@mircomir
Copy link
Contributor Author

I'm not sure this is a good idea unless we can somehow convince the world to switch to use your fork and not the upstream one...

...oh i see there's no upstream one?

Before proposing the PR I made the same reasoning as you. But then I thought: what is kimageformats on oss fuzz for? My answer: To solve the security problems of plugins in kimageformats.

With this PR I hope to close all those issues on OSS-Fuzz that get stuck on assert. And at the same time have a slightly more reliable version of the library. Better than doing nothing. Don't you think?

Should we try to convince Linux distributions to switch to your repository?

We deactivated the plugin in kimageformats because the library is practically abandonware (but it is still present in all distros) so we don't have to convince anyone to use a fork :)

I suggest trying the library here with our plugin and see how things evolve.

@tsdgeos
Copy link
Contributor

tsdgeos commented Nov 10, 2024

ok fair enough.

Admins please merge this.

@DavidKorczynski DavidKorczynski merged commit 19b2d43 into google:master Nov 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants