Skip to content

Conversation

@xingyaner
Copy link
Contributor

Upgrade the Make build to CMake

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

xingyaner is a new contributor to projects/croaring. The PR must be approved by known contributors before it can be merged. The past contributors are: maflcko, nathaniel-brough, lemire, K2

Copy link
Collaborator

@DavidKorczynski DavidKorczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am not sure about this PR as not it has 0 changes done.

The first one introduced a build.sh which is not how the upstream project does it.

Please coordinate with maintainers for these PRs.

change the copyright year
This reverts commit 20b6aac.
@xingyaner
Copy link
Contributor Author

Thank you for the feedback. I'll coordinate with the upstream maintainers regarding these changes. From my analysis, the CRoaring configuration currently has two key issues for OSS-Fuzz integration:
1、Insufficient Sanitizer Flags: The default sanitizer configuration lacks several flags required by OSS-Fuzz, such as -fsanitize=fuzzer-no-link and -Wno-error=....
2、Incorrect Compiler Selection: The CMake build system directly calls the system compiler instead of respecting the $CC environment variable provided by OSS-Fuzz, which points to a dedicated compiler wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants