Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade nodejs/nan to 2.22 #303

Merged
merged 1 commit into from
Feb 3, 2025
Merged

chore: upgrade nodejs/nan to 2.22 #303

merged 1 commit into from
Feb 3, 2025

Conversation

benminer
Copy link
Contributor

This PR upgrades nan to version 2.22, ensuring compatibility on NodeJS 21 and greater.

The main culprit when building pprof was SetAccessor being renamed, see here: nodejs/nan@6bd62c9

npm run test: ✅
system-test/system_test.sh: ✅

Copy link

google-cla bot commented Jan 29, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@aabmass
Copy link
Member

aabmass commented Feb 3, 2025

Thanks for the PR @benminer! Are you able to sign the CLA?

@aabmass
Copy link
Member

aabmass commented Feb 3, 2025

Also please see the conventional commits check and update the commit/PR

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.92%. Comparing base (dead429) to head (a4e49e7).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #303   +/-   ##
=======================================
  Coverage   41.92%   41.92%           
=======================================
  Files          14       14           
  Lines        2092     2092           
  Branches       42       42           
=======================================
  Hits          877      877           
  Misses       1197     1197           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benminer benminer changed the title upgrade nan to 2.22 chore: upgrade nodejs/nan to 2.22 Feb 3, 2025
@benminer
Copy link
Contributor Author

benminer commented Feb 3, 2025

Thanks for the PR @benminer! Are you able to sign the CLA?

Hey @aabmass - thanks for checking in. I did, but looks like it went under my default Gmail account rather than the address I committed with. Fixed now - is there a way to re-run that check? Looks like it reran with my amended commit push.

Also please see the conventional commits check and update the commit/PR

For sure, should be good now!

@aabmass
Copy link
Member

aabmass commented Feb 3, 2025

Thanks! I'll try to enable Node 21 tests and see what happens. There were some test failures #283 idk if you have any idea on that?

@aabmass aabmass enabled auto-merge (squash) February 3, 2025 18:54
@benminer
Copy link
Contributor Author

benminer commented Feb 3, 2025

Thanks! I'll try to enable Node 21 tests and see what happens. There were some test failures #283 idk if you have any idea on that?

I'll check it out!

@aabmass aabmass merged commit 8b27dff into google:main Feb 3, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants