Skip to content

Show the Welcome modal on the dashboard. #12036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfmohit merged 6 commits into from
Jan 12, 2026
Merged

Show the Welcome modal on the dashboard. #12036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a969e29
Show the Welcome modal on the dashboard.
techanvil Jan 6, 2026
cb7a435
Prevent tooltip from appearing when clicking "Start tour".
techanvil Jan 6, 2026
6933801
Extend test coverage for `WelcomeModal`.
techanvil Jan 6, 2026
7948316
Update comment.
techanvil Jan 6, 2026
a65dacd
Update test name.
techanvil Jan 6, 2026
60516c0
Remove unnecessary component state.
techanvil Jan 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion assets/js/components/DashboardMainApp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ import SurveyViewTrigger from './surveys/SurveyViewTrigger';
import CurrentSurveyPortal from './surveys/CurrentSurveyPortal';
import MetricsSelectionPanel from './KeyMetrics/MetricsSelectionPanel';
import UserSettingsSelectionPanel from './email-reporting/UserSettingsSelectionPanel';
import WelcomeModal from './WelcomeModal';
import { useFeature } from '@/js/hooks/useFeature';
import {
ANCHOR_ID_CONTENT,
Expand Down Expand Up @@ -229,6 +230,7 @@ export default function DashboardMainApp() {
} );

const emailReportingEnabled = useFeature( 'proactiveUserEngagement' );
const setupFlowRefreshEnabled = useFeature( 'setupFlowRefresh' );

useMonitorInternetConnection();

Expand Down Expand Up @@ -320,7 +322,6 @@ export default function DashboardMainApp() {
lastWidgetAnchor === ANCHOR_ID_MONETIZATION,
} ) }
/>
<OfflineNotification />
Copy link
Collaborator Author

@techanvil techanvil Jan 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's out of scope, but I've removed this duplicate <OfflineNotification />, having spotted that it's rendered twice when it should only be rendered once.

</div>

<SurveyViewTrigger
Expand All @@ -336,6 +337,8 @@ export default function DashboardMainApp() {

{ configuredAudiences && <AudienceSelectionPanel /> }

{ setupFlowRefreshEnabled && <WelcomeModal /> }

<OfflineNotification />
</Fragment>
);
Expand Down
Loading
Loading