Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow SkImage::asyncRescaleAndReadPixels() to work async on WebGL #169

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

allow SkImage::asyncRescaleAndReadPixels() to work async on WebGL #169

wants to merge 5 commits into from

Commits on Mar 28, 2024

  1. allow SkImage::asyncRescaleAndReadPixels() to work async on WebGL 

    Reading back pixels is blocking on WebGL. This is because skia lacks pixel
transfer support with out mapping.

WebGL has PBO for async reading, however it use `glGetBufferSubData()` to read
back from PIXEL_PACK_BUFFER instead of mapping

- add GetBufferSubData to GrGLInterface
- add GrGpuBuffer::getData()
- TAsyncReadResult use getData() to copy pixels to cpu plane
    @jamesruan
    jamesruan committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    3036904 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. use autogen tool

    @jamesruan
    jamesruan committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    68c9d5a View commit details
    Browse the repository at this point in the history

  2. fix GrGLBuffer logic

    @jamesruan
    jamesruan committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    8289c8b View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. add tests and fix caps detection

    @jamesruan
    jamesruan committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    fd15584 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2024

  1. fix

    @jamesruan
    jamesruan committed Apr 3, 2024
    Configuration menu
    Copy the full SHA
    d537ec6 View commit details
    Browse the repository at this point in the history