Refactored file jsguide.js#793
Closed
khaidao000 wants to merge 1 commit intogoogle:gh-pagesfrom
Closed
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
vapier
requested changes
Jul 9, 2024
Member
vapier
left a comment
vapier
left a comment
There was a problem hiding this comment.
please break this up into multiple changes. there's good stuff in here, but squashing all of this rewrite into a single commit makes it difficult/impossible to reasonably review, and makes it hard to detect bugs or unintentional changes in behavior.
Member
|
feel free to re-open or open a new PR if you plan on addressing the feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring includes:
Using querySelector for simplicity where possible.
Utilizing Array.prototype.forEach.call to directly iterate over NodeList.
Utilizing const for variable declarations where possible.
Simplifying if conditions.
Grouping similar logic and segregating different logic with line breaks for readability.