Skip to content

dasboard/app: redesing of navbar #6278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

dasboard/app: redesing of navbar #6278

wants to merge 38 commits into from

Conversation

gc2lgno
Copy link

@gc2lgno gc2lgno commented Aug 12, 2025

No description provided.

@tarasmadan tarasmadan self-requested a review August 12, 2025 15:52
@tarasmadan
Copy link
Collaborator

Error: Wrong commit subject format: 'dasboard/app/tenplates/templates.html: Redesing of navbar'. Please use 'main/affected/package: short change description'. See docs/contributing.md for details. Regex pattern used to check commit subjects is '^(Revert "|(([a-z0-9/_.-]+|Makefile|CONTRIBUTORS|README.md)(, )?)+:\ [^A-Z].+[^.]$)'.

"dasboard/app: redesing of navbar" should work. For both commits.

Feel free to merge these commits in order to simplify changes.

@gc2lgno gc2lgno changed the title dashboard/app: Redesing of navbar and Boostrap CDN dasboard/app: redesing of navba Aug 18, 2025
@gc2lgno gc2lgno changed the title dasboard/app: redesing of navba dasboard/app: redesing of navbar Aug 18, 2025
@tarasmadan
Copy link
Collaborator

There are many dashboard errors. You can find them in the log by "FAIL:" prefix:

--- FAIL: TestFileCoverage (0.00s)
    --- FAIL: TestFileCoverage/regular_db (6.64s)
        util_test.go:344: GET: /test2/coverage/file?dateto=2025-01-31&period=month&commit=c0e75905caf368e19aab585d20151500e750de89&filepath=virt/kvm/kvm_main.c
        util_test.go:363: REPLY: 200
        util_test.go:344: GET: /test1
        util_test.go:363: REPLY: 500
        util_test.go:177: expected OK, got error: 500: <!doctype html>
            <html>
            <head>
            	
            	
            	 
            	<link href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" rel="stylesheet"
                    integrity="sha384-4Q6Gf2aSP4eDXB8Miphtr37CMZZQ5oXLH2yaXMJ2w8e2ZtHTl7GptT4jmndRuHDT" crossorigin="anonymous">
            	<script src="/static/common.js"></script>
            	
            
            	<title>syzbot</title>
            </head>
            <body>
            	traceID: 
            	<br>
            	template: templates.html:90:39: executing &#34;header&#34; at &lt;$.BugCounts.MissingBackports&gt;: can&#39;t evaluate field MissingBackports in type *main.CachedBugStats
            	<br>
            	<a href="javascript:history.back()">back</a>
            </body>
            </html>
    --- FAIL: TestFileCoverage/empty_db (7.64s)
        util_test.go:344: GET: /test2/coverage/file?dateto=2025-01-31&period=month&commit=c0e75905caf368e19aab585d20151500e750de89&filepath=virt/kvm/kvm_main.c
        util_test.go:363: REPLY: 200
        util_test.go:344: GET: /test1
        util_test.go:363: REPLY: 500
        util_test.go:177: expected OK, got error: 500: <!doctype html>
            <html>
            <head>
            	
            	
            	 
            	<link href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" rel="stylesheet"
                    integrity="sha384-4Q6Gf2aSP4eDXB8Miphtr37CMZZQ5oXLH2yaXMJ2w8e2ZtHTl7GptT4jmndRuHDT" crossorigin="anonymous">
            	<script src="/static/common.js"></script>
            	
            
            	<title>syzbot</title>
            </head>
            <body>
            	traceID: 
            	<br>
            	template: templates.html:90:39: executing &#34;header&#34; at &lt;$.BugCounts.MissingBackports&gt;: can&#39;t evaluate field MissingBackports in type *main.CachedBugStats
            	<br>
            	<a href="javascript:history.back()">back</a>
            </body>
            </html>
    --- FAIL: TestFileCoverage/multimanager_db (7.66s)
        util_test.go:344: GET: /test2/coverage/file?dateto=2025-01-31&period=month&commit=c0e75905caf368e19aab585d20151500e750de89&filepath=virt/kvm/kvm_main.c&manager=special-cc-manager&unique-only=1
        util_test.go:363: REPLY: 200
        util_test.go:344: GET: /test1
        util_test.go:363: REPLY: 500
        util_test.go:177: expected OK, got error: 500: <!doctype html>
            <html>
            <head>
            	
            	
            	 
            	<link href="https://cdn.jsdelivr.net/npm/[email protected]/dist/css/bootstrap.min.css" rel="stylesheet"
                    integrity="sha384-4Q6Gf2aSP4eDXB8Miphtr37CMZZQ5oXLH2yaXMJ2w8e2ZtHTl7GptT4jmndRuHDT" crossorigin="anonymous">
            	<script src="/static/common.js"></script>
            	
            
            	<title>syzbot</title>
            </head>
            <body>
            	traceID: 
            	<br>
            	template: templates.html:90:39: executing &#34;header&#34; at &lt;$.BugCounts.MissingBackports&gt;: can&#39;t evaluate field MissingBackports in type *main.CachedBugStats
            	<br>
            	<a href="javascript:history.back()">back</a>
            </body>
            </html>

@a-nogikh
Copy link
Collaborator

It would be great to have some dev deployment to see what the updated interface looks like or at least the screenshots of it.

@tarasmadan
Copy link
Collaborator

We'll see it once the dashboard tests are fixed.

@tarasmadan
Copy link
Collaborator

Attaching 2 full window screenshots to simplify comparison:

  1. Information density need to be higher. Currently this table costs less than 1 screen from the height perspective.
  2. Instances (tested repos) link is missing.
  3. Not all the table columns have names.
  4. "failing" links should be red.
  5. Numbers are better to be right aligned to simplify comparison.
  6. Menu is better to drop down on hovering, not click.
image image

Talking about the "fixed" page:

  1. Multiple alignment problems/sizing problems.
  2. UI doesn't explain where we are now. Current menu highlights the current position. New doesn't.
image

gc2lgno added 11 commits August 26, 2025 16:25
@gc2lgno
dashboard/app: update table styles and enhance layout for better read…
d524dd8 
…ability
@gc2lgno
dashboard/app: Templates and main navbar adjust
99a754d
@gc2lgno
Revert "dashboard/app: Templates and main navbar adjust"
8834cd8 
This reverts commit 99a754d.
@gc2lgno
dashboard/app: Moving header to main.html
14515b2
@gc2lgno
dashboard/app: Invoking main/header on templates
4411322
@gc2lgno
dashboard/app: Fix template invocation for header in templates.html
ef8c3e8
@gc2lgno
dashobard/app: Refactor templates: restructure main layout and header…
ec11e44 
… components for improved organization and maintainability.
@gc2lgno
dashboard/app: Update template glob to include layouts and partials f…
7e70a74 
…or better organization
@gc2lgno
Update template glob to include all HTML files for improved flexibility
62b84be
@gc2lgno
dashboard/app: Improve glob validation and update comments for clarity
3455d39
@gc2lgno
Revert "dashboard/app: Improve glob validation and update comments fo…
325ec25 
…r clarity"

This reverts commit 3455d39.
gc2lgno added 16 commits September 3, 2025 17:21
@gc2lgno
Revert "Update template glob to include all HTML files for improved f…
1564022 
…lexibility"

This reverts commit 62b84be.
@gc2lgno
Revert "dashboard/app: Update template glob to include layouts and pa…
63b16e2 
…rtials for better organization"

This reverts commit 7e70a74.
@gc2lgno
Revert "dashobard/app: Refactor templates: restructure main layout an…
33cdc00 
…d header components for improved organization and maintainability."

This reverts commit ec11e44.
@gc2lgno
dashboard/app: Implement base layout and header components for improv…
9a0d3a0 
…ed structure and reusability
@gc2lgno
dashboard/app: Remove footer template inclusion from base layout for …
113487b 
…cleaner structure
@gc2lgno
Revert "dashboard/app: Remove footer template inclusion from base lay…
fbcf874 
…out for cleaner structure"

This reverts commit 113487b.
@gc2lgno
Revert "dashboard/app: Implement base layout and header components fo…
bd5b626 
…r improved structure and reusability"

This reverts commit 9a0d3a0.
@gc2lgno
Revert "dashboard/app: Fix template invocation for header in template…
702b93e 
…s.html"

This reverts commit ef8c3e8.
@gc2lgno
Revert "dashboard/app: Invoking main/header on templates"
7ea412c 
This reverts commit 4411322.
@gc2lgno
Revert "dashboard/app: Moving header to main.html"
dddcca2 
This reverts commit 14515b2.
@gc2lgno
Dashboard app: Removing container class from rows.
e8b5a5d 
Including div class container on main.html
@gc2lgno
Dashboard: Templates: Fixing line 313. "tested repos" jumped line
44eec67
@gc2lgno
Dashboard: Templates: Recovering jumped lines due Formatting Document
73adb88
@gc2lgno
Dashboard: Templates: Fixing formatting issue in bisection links
6489253
@gc2lgno
Dashboard: Templates: Changing container class to row for better layout
cc1feb6
@gc2lgno
Dashboard: Templates: Refactoring: Removing <main> from templates.htm…
c3bec5d 
…l and moving it to Main HTML
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarasmadan tarasmadan Awaiting requested review from tarasmadan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gc2lgno @tarasmadan @a-nogikh