Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduction of final Docker image size by 48% #76

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Reduction of final Docker image size by 48% #76

merged 2 commits into from
Mar 3, 2021

Conversation

gaby
Copy link
Contributor

@gaby gaby commented Feb 26, 2021

  • Replaces opendjk:13-jdk-slim-buster image with AdoptOpenJDK variants.
  • Reduces size of final image from 1.07GB to 534MB a reduction of 48%
  • Final image only contains: jre, nmap, ncrack and the built jar files.

This PR complements #75 by reducing the size of the image being published.

Build process now uses: adoptopenjdk/openjdk13:debianslim
Final image uses: adoptopenjdk/openjdk13:debianslim-jre

Refactor Dockerfile and reduce size of final image from 1.07GB to 534MB
@google-cla google-cla bot added the cla: yes label Feb 26, 2021
@gaby
Copy link
Contributor Author

gaby commented Feb 26, 2021

I had one question, would it be possible for tsunami to run with OpenJDK 14 or 15? Those images are updated more often than 13.

@gaby
Copy link
Contributor Author

gaby commented Mar 2, 2021

@erikvarga @magl0 Feedback on this would be appreciated.

@magl0
Copy link
Collaborator

magl0 commented Mar 2, 2021

possible for tsunami to run with OpenJDK 14 or 15?

I think so, but this was not tested so I'd like to perform some testing first before switching. And ideally we should stick with a LTS release of Java in the future.

@magl0
Copy link
Collaborator

magl0 commented Mar 2, 2021

PR pending internal review.

Dockerfile Outdated Show resolved Hide resolved
Added newline
@copybara-service copybara-service bot merged commit f2e7dbe into google:master Mar 3, 2021
@gaby gaby deleted the docker-optimize branch March 29, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants