-
Notifications
You must be signed in to change notification settings - Fork 59
feat: add support for .editorconfig #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, looks like a good start. Can you also add an integration test case that leverages a .editorconfig
? The guidance for how to add a test case is here:
https://github.com/google/yamlfmt/blob/main/docs/integration-test.md#add-new-test-case
gopkg.in/ini.v1 v1.67.0 // indirect | ||
) | ||
|
||
require ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this need a go mod tidy
; not sure why it added this extra require
block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, that's a good question. Another good one is why go mod tidy
only touches go.sum
...
Sure! I'm just thinking that this probably isn't as straight forward as I thought. The "Automatic search for |
Yup, that's the case. So basically |
Fixes #61.