-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provide support for .env files injects via API #1034
Merged
Merged
+78
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easymikey
changed the title
Feat add envpath to core
feat: provide support for .env files injects via API
Dec 25, 2024
What's about this way instead? const loadDotenv = (...files: string[]) => files.reverse().reduce<env>((m, f) => Object.assign(m, parseDotenv(fs.readFileSync(f))), {})
$.env = loadDotenv('.env', '.env.default') |
antongolub
reviewed
Dec 25, 2024
Maybe replace it with spread? const loadDotenv = (...files: string[]) =>
files
.reverse()
.reduce<env>((m, f) => ({ ...m, ...parseDotenv(fs.readFileSync(f)) }), {}); And why the reverse? $.env = loadDotenv('.env.default', '.env') Are you suggesting we consider an array of strings as well? type Env = NodeJs.Process | string | string[] |
I suggest keeping the |
easymikey
force-pushed
the
feat-add-envpath-to-core
branch
from
December 26, 2024 13:41
6fae7d2
to
28a2661
Compare
easymikey
force-pushed
the
feat-add-envpath-to-core
branch
from
December 26, 2024 14:36
28a2661
to
bb09653
Compare
antongolub
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks.
antongolub
added a commit
to antongolub/zx
that referenced
this pull request
Dec 28, 2024
2 tasks
antongolub
added a commit
that referenced
this pull request
Dec 28, 2024
* refactor: assemble dotenv utils continues #1034 * chore: prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #975