feat: protect ProcessPromise from inappropriate instantiation effects
#1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
antongolub
commented
Feb 10, 2025
antongolub
commented
- Tests pass
- Appropriate changes to README are included in PR
antonmedv
reviewed
Feb 10, 2025
src/core.ts
Outdated
| @@ -145,6 +145,7 @@ export interface Shell< | |||
| (opts: Partial<Omit<Options, 'sync'>>): Shell<true> | |||
| } | |||
| } | |||
| const bound: [boolean, string, string, Options][] = [] | |||
There was a problem hiding this comment.
Maybe object is better?
antonmedv
approved these changes
Feb 10, 2025
antongolub
force-pushed
the
pp-no-bind
branch
from
34d5b43 to
0dc5973
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.