Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(log): provide custom formatting for every entry kind #1123

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

antongolub
Copy link
Collaborator

@antongolub antongolub commented Mar 10, 2025

continues #1122

$.log.formatters = {
  cmd: (entry: LogEntry) => `CMD: ${entry.cmd}`,
  fetch: (entry: LogEntry) => `FETCH: ${entry.url}`
}
  • Tests pass
  • Appropriate changes to README are included in PR

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@antonmedv
Copy link
Collaborator

Do we really need a separate formatter, and a separate API for formatter for fetch? We kinda own all fetch functionality and can format as we'd like to.

@antongolub
Copy link
Collaborator Author

antongolub commented Mar 10, 2025

We capture the init opts which may contain headers with creds. The best place to attach masker if necessary w/o overriding the whole log.

image

@antonmedv antonmedv merged commit 2c4b5e8 into google:main Mar 10, 2025
26 checks passed
@antongolub antongolub deleted the custom-log-formatters branch March 10, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants