Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

investigate switching strcase libraries, or a full refactor to an internal variant #1150

Open
toumorokoshi opened this issue May 11, 2023 · 0 comments
Open

investigate switching strcase libraries, or a full refactor to an internal variant #1150

toumorokoshi opened this issue May 11, 2023 · 0 comments
Assignees
@toumorokoshi
Labels
priority: p2 type: process
Milestone
gcp-strict-aips-b...

Comments

@toumorokoshi
Copy link
Contributor

context: #1143 (comment).

#1143 introduces a new lower / upper file, which is partially redundant with go-strcase.

The change was introduced as go-strcase was too liberal with it's definition upperCamel / lowerCamel (allowing dashes and underscores through).

We should investigate whether we can remove existing usage with the internal variant, or switch to a new strcase library e.g. (https://github.com/iancoleman/strcase)
@toumorokoshi toumorokoshi self-assigned this May 11, 2023
@toumorokoshi toumorokoshi added this to the gcp-strict-aips-2023-12 milestone May 11, 2023
@toumorokoshi toumorokoshi mentioned this issue May 11, 2023
Merged
toumorokoshi added a commit that referenced this issue May 11, 2023
@toumorokoshi
feat(AIP-123): add singular and plural validation (#1143)
0d1ff55 
Matching AIP-123 in requiring singular and plural annotations,
and for singular matching the lowerCamelCase of type.

Wrote custom ToUpperCamelCase as existing one does not consider
underscores / dashes as invalid characters, which are considered
delimiters in the camel case conversion. Further investigation on replacing
it with #1150.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toumorokoshi toumorokoshi

Labels
priority: p2 type: process
Projects
None yet
Milestone
gcp-strict-aips-backlog
Development

No branches or pull requests
2 participants
@toumorokoshi @noahdietz