feat(AIP-123): add singular and plural validation #1143
Conversation
Matching AIP-123 in requiring singular and plural annotations, and for singular matching the lowerCamelCase of type.
- fixing all lint problems with suggested values. - writing custom ToUpperCamelCase as existing one does not consider underscores / dashes as invalid characters, which are considered delimiters in the camel case conversion.
|
@noahdietz finally ready for a pass! Thanks. |
|
|
||
| // ToUpperCamelCase returns the UpperCamelCase of a string, including removing | ||
| // delimiters (_,-,., ) and using them to denote a new word. | ||
| func ToUpperCamelCase(s string) string { |
There was a problem hiding this comment.
Sooooo we could totally switch to using this but....we already use strcase for this type of stuff: https://pkg.go.dev/github.com/stoewer/go-strcase 😬 Not sure we need this file, unless we want to drop the external/non-google dependency (which would be fine if that was a goal, I do see value in such a "clean" module approach)
There was a problem hiding this comment.
strcase doesn't filter out "-" or "_" unfortunately. I did see some hacks with double-conversion to snake case, then to upperCamelCase, but I figured it might be best to roll our own that matches our own definition of "upperCamelCase".
I did find this version of strcase that matches our definition: https://github.com/iancoleman/strcase. But I decided against switching it because we need to vet that it works for the other use cases as well.
There was a problem hiding this comment.
Maybe what is needed is an extensible casing lib e.g. with an Option type like WithDelimiters(delim ...string) and ToUpperCamelCase(s string, opts ...Option) string
Anyways, thanks for the clarification. It's a tad confusing when we'd use one or the other rn, so I think we should try to replace strcase with this sooner rather than later if possible.
There was a problem hiding this comment.
ack, here's a tracking issue: #1150. Agreed that mixed usage is confusing: i'll follow up to try to clean that up.
Once nice thing about our own handrolled one is we can add options as needed.
Matching AIP-123 in requiring singular and plural annotations, and for singular matching the lowerCamelCase of type.
Fixes #722, but needs guidance updated in the AIPs around the values first.