(feat aip-203): add linter for field_behavior presence #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
thanks for the change! We'll be closing this in favor of #1149 which has a little bit more of the recent guidance. |
|
cool ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP blocked by https://github.com/googleapis/api-linter/pull/966/files for warning level additions
AIP 203 uses /should/ quantifier so in alignment with strong recommendation we desire to add a warning linter.
We were originally looking to add this to ONLY gcp however the original document for AIP-203 already defines this requirement strongly. We are open to making this gcp only if desired.