Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO_NOT_MERGE test: system test node 14 and 16 #851

Closed
wants to merge 2 commits into from
Closed

DO_NOT_MERGE test: system test node 14 and 16 #851

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9279c89
test: system test node 14, 16, and 18
amchiclet Aug 15, 2022
c01f213
test: system test node 14 and 16
amchiclet Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions system-test/integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,25 +265,38 @@ func TestAgentIntegration(t *testing.T) {
InstanceConfig: proftest.InstanceConfig{
ProjectID: projectID,
Zone: zone,
Name: fmt.Sprintf("profiler-test-node12-%s", runID),
Name: fmt.Sprintf("profiler-test-node14-%s", runID),
MachineType: "n1-standard-1",
},
name: fmt.Sprintf("profiler-test-node12-%s-gce", runID),
name: fmt.Sprintf("profiler-test-node14-%s-gce", runID),
wantProfiles: wantProfiles,
nodeVersion: "12",
nodeVersion: "14",
timeout: gceTestTimeout,
benchDuration: gceBenchDuration,
},
{
InstanceConfig: proftest.InstanceConfig{
ProjectID: projectID,
Zone: zone,
Name: fmt.Sprintf("profiler-test-node14-%s", runID),
Name: fmt.Sprintf("profiler-test-node16-%s", runID),
MachineType: "n1-standard-1",
},
name: fmt.Sprintf("profiler-test-node14-%s-gce", runID),
name: fmt.Sprintf("profiler-test-node16-%s-gce", runID),
wantProfiles: wantProfiles,
nodeVersion: "14",
nodeVersion: "16",
timeout: gceTestTimeout,
benchDuration: gceBenchDuration,
},
{
InstanceConfig: proftest.InstanceConfig{
ProjectID: projectID,
Zone: zone,
Name: fmt.Sprintf("profiler-test-node18-%s", runID),
MachineType: "n1-standard-1",
},
name: fmt.Sprintf("profiler-test-node18-%s-gce", runID),
wantProfiles: wantProfiles,
nodeVersion: "18",
timeout: gceTestTimeout,
benchDuration: gceBenchDuration,
},
Expand All @@ -295,14 +308,14 @@ func TestAgentIntegration(t *testing.T) {
InstanceConfig: proftest.InstanceConfig{
ProjectID: projectID,
Zone: zone,
Name: fmt.Sprintf("profiler-backoff-test-node12-%s", runID),
Name: fmt.Sprintf("profiler-backoff-test-node14-%s", runID),

// Running many copies of the benchmark requires more
// memory than is available on an n1-standard-1. Use a
// machine type with more memory for backoff test.
MachineType: "n1-highmem-2",
},
name: fmt.Sprintf("profiler-backoff-test-node12-%s", runID),
name: fmt.Sprintf("profiler-backoff-test-node14-%s", runID),
backoffTest: true,
nodeVersion: "12",
timeout: backoffTestTimeout,
Expand Down