Skip to content

Commit

Permalink
chore(internal/gencli): remove use of github.com/golang/protobuf (#1555)
Browse files Browse the repository at this point in the history
For #1417
  • Loading branch information
julieqiu authored Aug 19, 2024
1 parent 53c66dc commit ad61ccf
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 8 deletions.
2 changes: 1 addition & 1 deletion internal/gencli/gencli.go
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ func (g *gcli) genCommands() {
})

putImport(cmd.Imports, &pbinfo.ImportSpec{
Path: "github.com/golang/protobuf/jsonpb",
Path: "google.golang.org/protobuf/jsonpb",
})

if !cmd.ClientStreaming {
Expand Down
4 changes: 2 additions & 2 deletions internal/gencli/root_file.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ import (
"fmt"
"os"
"github.com/golang/protobuf/jsonpb"
"github.com/golang/protobuf/proto"
"github.com/spf13/cobra"
"google.golang.org/protobuf/jsonpb"
"google.golang.org/protobuf/proto"
)
var Verbose, OutputJSON bool
Expand Down
3 changes: 1 addition & 2 deletions internal/gencli/service_file_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import (
"testing"

"github.com/googleapis/gapic-generator-go/internal/pbinfo"

"github.com/googleapis/gapic-generator-go/internal/txtdiff"
)

Expand All @@ -37,7 +36,7 @@ func TestServiceFile(t *testing.T) {
root: "Root",
format: true,
imports: map[string]*pbinfo.ImportSpec{
"test": &pbinfo.ImportSpec{Name: "proto", Path: "github.com/golang/protobuf/proto"},
"test": &pbinfo.ImportSpec{Name: "proto", Path: "google.golang.org/protobuf/proto"},
},
subcommands: map[string][]*Command{
name: []*Command{
Expand Down
4 changes: 2 additions & 2 deletions internal/gencli/testdata/root_file.want
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ import (
"fmt"
"os"

"github.com/golang/protobuf/jsonpb"
"github.com/golang/protobuf/proto"
"github.com/spf13/cobra"
"google.golang.org/protobuf/jsonpb"
"google.golang.org/protobuf/proto"
)

var Verbose, OutputJSON bool
Expand Down
2 changes: 1 addition & 1 deletion internal/gencli/testdata/service_file.want
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (
"google.golang.org/grpc"
"google.golang.org/grpc/credentials/insecure"

proto "github.com/golang/protobuf/proto"
proto "google.golang.org/protobuf/proto"
)

var TodoConfig *viper.Viper
Expand Down

0 comments on commit ad61ccf

Please sign in to comment.