Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(internal/snippets,gengapic): use sample values in tests #1513

Merged
merged 1 commit into from
May 13, 2024

Conversation

julieqiu
Copy link
Member

@julieqiu julieqiu commented May 13, 2024

Refactor TestNewMetadata, TestToMetadataJSON and TestRegionTag in internal/snippets/snippets_test.go to use the internal/testing/sample package.

For #1512

@julieqiu julieqiu requested review from a team as code owners May 13, 2024 23:16
@julieqiu julieqiu force-pushed the pr2 branch 3 times, most recently from 2102386 to 3b350ed Compare May 13, 2024 23:29
Refactor TestNewMetadata, TestToMetadataJSON and TestRegionTag in
internal/snippets/snippets_test.go to use the internal/testing/sample
package.

For googleapis#1512
@noahdietz noahdietz merged commit 779cd45 into googleapis:main May 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants