Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gencli): dont return iterator.Done #1533

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

liveFreeOrCode
Copy link

When generating a Paged method: https://google.aip.dev/132, the err at the end will always be an iterator.Done (as long as the iterator was built successfully).

List CLI methods should not return iterator.Done method.

@liveFreeOrCode liveFreeOrCode requested review from a team as code owners June 14, 2024 18:38
@noahdietz
Copy link
Collaborator

I keep finding that folks actually use this! haha Thanks for the fix, you might need to update the baselines as well.

@noahdietz
Copy link
Collaborator

you might need to update the baselines as well.

or not! that's a gap...would you mind adding a test case to the cmd_file_test.go? Then run
go test github.com/googleapis/gapic-generator-go/internal/gencli -update_golden to write the baseline to disk assuming it is correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants