-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade rules_go to 0.49.0 #1569
Conversation
* upgrade bazel_gazelle to 0.38.0 * upgrade com_google_protobuf to 25.4 * add rules_proto 6.0.2 * remove -use_generic_streams_experimental * fix error: protoc-gen-go-grpc: no such flag -use_generic_streams_experimental refs: googleapis#1554
We will need to take the "breaking change" introduced by this if we want to remove it. The change applies to our showcase testing stuff, so not that big of a deal tbh. grpc-go went from a stream client |
@noahdietz You mean we just need to merge this PR in spite of the failing apidiff, correct? Or do you think the merge commit should flag the breaking change with a bang, and that the release notes should mention it? |
@quartzmo have you tried to add this change to googleapis to see if it is compatible there? |
I ran |
@noahdietz My local |
@quartzmo I would try to build the whole package(so other langs too). The reason I ask is because our workspace in googleapis explicitly sets the version of some of these deps. But I think this change would cause them to raise: |
1b8ea21
to
4903ea7
Compare
@codyoss Thanks for pointing that out. I reverted the updates to |
refs: #1554