chore: add comment about http streaming sequence behavior #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experimenting a bunch with how to properly warn/error about the behavior we saw in #1377. The only handwritten place I could do so would be in
sequence_service.go, but I decided against that because afaik, at that point, the sequence service does not know if it was called via http or gRPC so the only way to warn about unexpected behavior would be to do so every single time, which seemed not great. Instead I decided to add a comment to the proto so it was at least written down somewhere. If y'all have a more clever spot though, I'm open to hearing where this could go!