Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add RPCs returning unknown enum values over REST #856

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

feat: add RPCs returning unknown enum values over REST #856

wants to merge 7 commits into from

Commits on Aug 25, 2021

  1. Infrastructure to provide REST-specific handlers via hooks 

    NEXT:
- clean up init function for go view creator
- add custom operation for unknown enum
    @vchudnov-g
    vchudnov-g committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    ed34451 View commit details
    Browse the repository at this point in the history

  2. Provide an unknown enum 

    NEXT: need tests, clean up code
    @vchudnov-g
    vchudnov-g committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    5bfe059 View commit details
    Browse the repository at this point in the history

  3. Added test for TestRepeatWithUnknownEnum 

    Asa  result of the test, also fixed NPE by ensuring submessages are present before referencing them.
    @vchudnov-g
    vchudnov-g committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    acba666 View commit details
    Browse the repository at this point in the history

  4. Add and implement RepeatWithUnknownOptionalEnum RPC 

    Need to test this next.
    @vchudnov-g
    vchudnov-g committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    1143406 View commit details
    Browse the repository at this point in the history

  5. Add test for RepeatWithUnknownOptionalEnum

    @vchudnov-g
    vchudnov-g committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    1ee9d48 View commit details
    Browse the repository at this point in the history

  6. Use non-zero value as a sentinel 

    This allows isolating unknown enum values in specific fields.
    @vchudnov-g
    vchudnov-g committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    ea6a882 View commit details
    Browse the repository at this point in the history

  7. Cosmetic fixes.

    @vchudnov-g
    vchudnov-g committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    3b54211 View commit details
    Browse the repository at this point in the history