feat: add support and tests for webpack #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinBeckwith
changed the title
JustinBeckwith
suggested changes
Feb 12, 2019
|
Oh, you have |
|
@JustinBeckwith It's ready for one more look! |
| await execa('npx', ['webpack'], {cwd: `${stagingPath}/`, stdio: 'inherit'}); | ||
| const bundle = path.join(stagingPath, 'dist', 'bundle.min.js'); | ||
| const stat = fs.statSync(bundle); | ||
| assert(stat.size < 256 * 1024); |
JustinBeckwith
approved these changes
Feb 12, 2019
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44. Turns out gaxios cannot pass querystring parameters when running in the browser because of the bad
URLpolyfill used. We don't need to have any polyfill forURLsince we havewindow.URL, so let's use it.Also, added some tests for browser.