feat(tools/looker): Report field suggestions to agent #1267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drstrangelooker
force-pushed
the
looker-suggestions
branch
from
0a4f6ec to
6d1751e
Compare
drstrangelooker
force-pushed
the
looker-suggestions
branch
from
6d1751e to
22a1ebc
Compare
drstrangelooker
force-pushed
the
looker-suggestions
branch
from
22a1ebc to
ab99661
Compare
Yuan325
requested changes
Aug 28, 2025
drstrangelooker
force-pushed
the
looker-suggestions
branch
from
7edc598 to
8aba184
Compare
drstrangelooker
force-pushed
the
looker-suggestions
branch
from
8aba184 to
9f8e8d4
Compare
drstrangelooker
force-pushed
the
looker-suggestions
branch
from
9f8e8d4 to
2700ae0
Compare
|
Can I get an LGTM? |
|
🧨 Preview deployments removed. |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2025
## Description --- Report the LookML suggestions array or the suggst_explore and suggest_dimension to the caller so that the caller can use those suggestions to improve filtering. ## PR Checklist --- > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/langchain-google-alloydb-pg-python/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #1247 2cad82e
github-actions bot
pushed a commit
to renovate-bot/googleapis-_-genai-toolbox
that referenced
this pull request
Sep 3, 2025
…apis#1267) ## Description --- Report the LookML suggestions array or the suggst_explore and suggest_dimension to the caller so that the caller can use those suggestions to improve filtering. ## PR Checklist --- > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/langchain-google-alloydb-pg-python/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#1247 2cad82e
github-actions bot
pushed a commit
to bhardwajRahul/genai-toolbox
that referenced
this pull request
Sep 3, 2025
…apis#1267) ## Description --- Report the LookML suggestions array or the suggst_explore and suggest_dimension to the caller so that the caller can use those suggestions to improve filtering. ## PR Checklist --- > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/langchain-google-alloydb-pg-python/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#1247 2cad82e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Report the LookML suggestions array or the suggst_explore and suggest_dimension to the caller so
that the caller can use those suggestions to improve filtering.
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #1247