feat(source/mysql): support `queryParams` in MySQL source #1299

govegasbudapest · 2025-08-31T14:09:55Z

Motivation

Allow secure connections to PostgreSQL without custom code.

Changes

Sources

mysql: Config.QueryParams added; DSN building rewritten via url.Values.

google-cla · 2025-08-31T14:10:00Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

…L configs

Yuan325

Hi @govegasbudapest thankyou for contributing! If you can update the docs that will be great too! ref: #1047

internal/prebuiltconfigs/tools/mysql.yaml

internal/sources/postgres/postgres.go

internal/sources/mysql/mysql.go

Yuan325

Thank you for your prompt response! Left a couple more comments on the changes.

internal/sources/mysql/mysql.go

internal/sources/mysql/mysql_test.go

internal/prebuiltconfigs/tools/mysql.yaml

Co-authored-by: Yuan Teoh <[email protected]>

Yuan325

@govegasbudapest Awesome, thank you for your contribution!! :)

Yuan325 · 2025-09-03T16:43:48Z

/gcbrun

Yuan325 · 2025-09-03T17:04:30Z

/gcbrun

Yuan325 · 2025-09-03T17:27:37Z

/gcbrun

Yuan325 · 2025-09-03T17:30:51Z

/gcbrun

) Fixes #1286 ### Motivation * Allow secure connections to PostgreSQL without custom code. ### Changes #### Sources * `mysql`: `Config.QueryParams` added; DSN building rewritten via `url.Values`. --------- Co-authored-by: Yuan Teoh <[email protected]> Co-authored-by: Yuan Teoh <[email protected]> 3ae2526

🤖 I have created a release *beep* *boop* --- ## [0.14.0](v0.13.0...v0.14.0) (2025-09-05) ### ⚠ BREAKING CHANGES * **bigquery:** Move `useClientOAuth` config from tool to source ([#1279](#1279)) ([8d20a48](8d20a48)) * **tools/bigquerysql:** remove `useClientOAuth` from tools config ([#1312](#1312)) ### Features * **clickhouse:** Add ClickHouse Source and Tools ([#1088](#1088)) ([75a04a5](75a04a5)) * **prebuilt/alloydb-postgres:** Support ipType and IAM users ([#1324](#1324)) ([0b2121e](0b2121e)) * **server/mcp:** Support toolbox auth in mcp ([#1140](#1140)) ([ca353e0](ca353e0)) * **source/mysql:** Support `queryParams` in MySQL source ([#1299](#1299)) ([3ae2526](3ae2526)) * **tools/bigquery:** Support end-user credential passthrough on multiple BQ tools ([#1314](#1314)) ([88f4b30](88f4b30)) * **tools/looker:** Add description for looker-get-models tool ([#1266](#1266)) ([89af3a4](89af3a4)) * **tools/looker:** Authenticate via end user credentials ([#1257](#1257)) ([8755e3d](8755e3d)) * **tools/looker:** Report field suggestions to agent ([#1267](#1267)) ([2cad82e](2cad82e)) ### Bug Fixes * Do not print usage on runtime error ([#1315](#1315)) ([afba7a5](afba7a5)) * Update env var to allow empty string ([#1260](#1260)) ([03aa9fa](03aa9fa)) * **tools/firestore:** Add document/collection path validation ([#1229](#1229)) ([14c2249](14c2249)) * **tools/looker-get-dashboards:** Fix Looker client OAuth check ([#1338](#1338)) ([36225aa](36225aa)) * **tools/oceanbase:** Fix encoded text with mysql driver ([#1283](#1283)) ([d16f89f](d16f89f)), closes [#1161](#1161) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <[email protected]>

🤖 I have created a release *beep* *boop* --- ## [0.14.0](v0.13.0...v0.14.0) (2025-09-05) ### ⚠ BREAKING CHANGES * **bigquery:** Move `useClientOAuth` config from tool to source ([#1279](#1279)) ([8d20a48](8d20a48)) * **tools/bigquerysql:** remove `useClientOAuth` from tools config ([#1312](#1312)) ### Features * **clickhouse:** Add ClickHouse Source and Tools ([#1088](#1088)) ([75a04a5](75a04a5)) * **prebuilt/alloydb-postgres:** Support ipType and IAM users ([#1324](#1324)) ([0b2121e](0b2121e)) * **server/mcp:** Support toolbox auth in mcp ([#1140](#1140)) ([ca353e0](ca353e0)) * **source/mysql:** Support `queryParams` in MySQL source ([#1299](#1299)) ([3ae2526](3ae2526)) * **tools/bigquery:** Support end-user credential passthrough on multiple BQ tools ([#1314](#1314)) ([88f4b30](88f4b30)) * **tools/looker:** Add description for looker-get-models tool ([#1266](#1266)) ([89af3a4](89af3a4)) * **tools/looker:** Authenticate via end user credentials ([#1257](#1257)) ([8755e3d](8755e3d)) * **tools/looker:** Report field suggestions to agent ([#1267](#1267)) ([2cad82e](2cad82e)) ### Bug Fixes * Do not print usage on runtime error ([#1315](#1315)) ([afba7a5](afba7a5)) * Update env var to allow empty string ([#1260](#1260)) ([03aa9fa](03aa9fa)) * **tools/firestore:** Add document/collection path validation ([#1229](#1229)) ([14c2249](14c2249)) * **tools/looker-get-dashboards:** Fix Looker client OAuth check ([#1338](#1338)) ([36225aa](36225aa)) * **tools/oceanbase:** Fix encoded text with mysql driver ([#1283](#1283)) ([d16f89f](d16f89f)), closes [#1161](#1161) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <[email protected]> 4f022b6

🤖 I have created a release *beep* *boop* --- ## [0.14.0](googleapis/genai-toolbox@v0.13.0...v0.14.0) (2025-09-05) ### ⚠ BREAKING CHANGES * **bigquery:** Move `useClientOAuth` config from tool to source ([googleapis#1279](googleapis#1279)) ([8d20a48](googleapis@8d20a48)) * **tools/bigquerysql:** remove `useClientOAuth` from tools config ([googleapis#1312](googleapis#1312)) ### Features * **clickhouse:** Add ClickHouse Source and Tools ([googleapis#1088](googleapis#1088)) ([75a04a5](googleapis@75a04a5)) * **prebuilt/alloydb-postgres:** Support ipType and IAM users ([googleapis#1324](googleapis#1324)) ([0b2121e](googleapis@0b2121e)) * **server/mcp:** Support toolbox auth in mcp ([googleapis#1140](googleapis#1140)) ([ca353e0](googleapis@ca353e0)) * **source/mysql:** Support `queryParams` in MySQL source ([googleapis#1299](googleapis#1299)) ([3ae2526](googleapis@3ae2526)) * **tools/bigquery:** Support end-user credential passthrough on multiple BQ tools ([googleapis#1314](googleapis#1314)) ([88f4b30](googleapis@88f4b30)) * **tools/looker:** Add description for looker-get-models tool ([googleapis#1266](googleapis#1266)) ([89af3a4](googleapis@89af3a4)) * **tools/looker:** Authenticate via end user credentials ([googleapis#1257](googleapis#1257)) ([8755e3d](googleapis@8755e3d)) * **tools/looker:** Report field suggestions to agent ([googleapis#1267](googleapis#1267)) ([2cad82e](googleapis@2cad82e)) ### Bug Fixes * Do not print usage on runtime error ([googleapis#1315](googleapis#1315)) ([afba7a5](googleapis@afba7a5)) * Update env var to allow empty string ([googleapis#1260](googleapis#1260)) ([03aa9fa](googleapis@03aa9fa)) * **tools/firestore:** Add document/collection path validation ([googleapis#1229](googleapis#1229)) ([14c2249](googleapis@14c2249)) * **tools/looker-get-dashboards:** Fix Looker client OAuth check ([googleapis#1338](googleapis#1338)) ([36225aa](googleapis@36225aa)) * **tools/oceanbase:** Fix encoded text with mysql driver ([googleapis#1283](googleapis#1283)) ([d16f89f](googleapis@d16f89f)), closes [googleapis#1161](googleapis#1161) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Yuan Teoh <[email protected]> 4f022b6

govegasbudapest requested a review from a team as a code owner August 31, 2025 14:09

blunderbuss-gcf bot assigned averikitsch Aug 31, 2025

govegasbudapest added 2 commits August 31, 2025 17:28

feat(sources): add TLS/SSL configuration support for MySQL and Postgres

5cad505

docs(prebuilt): expose MYSQL_TLS and POSTGRES_SSLMODE env vars in YAM…

7b31be3

…L configs

govegasbudapest force-pushed the issue-1286-mysql-postgres-tls branch from 898d7a4 to 7b31be3 Compare August 31, 2025 14:29

kurtisvg assigned Yuan325 and unassigned averikitsch Sep 1, 2025

Yuan325 requested changes Sep 2, 2025

View reviewed changes

internal/prebuiltconfigs/tools/mysql.yaml Outdated Show resolved Hide resolved

internal/sources/postgres/postgres.go Outdated Show resolved Hide resolved

internal/sources/mysql/mysql.go Show resolved Hide resolved

govegasbudapest added 2 commits September 2, 2025 22:51

ISSUE-1286: Revert Postgres TLS config to origin/main state

b0dc60a

issue-1286: Expand MySQL source YAML tests and improve error coverage

2fc6e73

govegasbudapest changed the title ~~feat: TLS/SSL support for MySQL and Postgres sources (#1286)~~ feat: add TLS & query param support to MySQL source and expand YAML tests (#1286) Sep 2, 2025

govegasbudapest added 2 commits September 2, 2025 23:05

issue-1286: Add Apache license header to MySQL prebuilt config

f2dcf07

Merge branch 'main' into issue-1286-mysql-postgres-tls

ae5e4ce

govegasbudapest requested a review from Yuan325 September 2, 2025 20:08

issue-1286: Update MySQL source docs with queryParams and TLS examples

13b2494

Yuan325 requested changes Sep 2, 2025

View reviewed changes

govegasbudapest and others added 9 commits September 3, 2025 09:57

Update internal/sources/mysql/mysql.go

7ce1a39

Co-authored-by: Yuan Teoh <[email protected]>

Update internal/sources/mysql/mysql_test.go

747e7a2

Co-authored-by: Yuan Teoh <[email protected]>

Update internal/sources/mysql/mysql_test.go

247e77b

Co-authored-by: Yuan Teoh <[email protected]>

Update internal/sources/mysql/mysql_test.go

45c15e9

Co-authored-by: Yuan Teoh <[email protected]>

Update internal/sources/mysql/mysql_test.go

cb59baf

Co-authored-by: Yuan Teoh <[email protected]>

Update internal/sources/mysql/mysql_test.go

51f9bcc

Co-authored-by: Yuan Teoh <[email protected]>

Merge branch 'main' into issue-1286-mysql-postgres-tls

f6e5759

issue-1286: Simplify MySQL source YAML error tests

bf3a6cb

issue-1286: Revert MySQL prebuiltconfig changes to move into separate PR

b51c430

govegasbudapest requested a review from Yuan325 September 3, 2025 07:48

Update mysql.md

91c220a

Yuan325 approved these changes Sep 3, 2025

View reviewed changes

Yuan325 added the tests: run Label to trigger Github Action tests. label Sep 3, 2025

github-actions bot removed the tests: run Label to trigger Github Action tests. label Sep 3, 2025

Yuan325 changed the title ~~feat: add TLS & query param support to MySQL source and expand YAML tests (#1286)~~ feat: support queryParams in MySQL source Sep 3, 2025

Yuan325 changed the title ~~feat: support queryParams in MySQL source~~ feat(source/mysql): support queryParams in MySQL source Sep 3, 2025

Update mysql_test.go

b12da2e

Yuan325 added the tests: run Label to trigger Github Action tests. label Sep 3, 2025

github-actions bot removed the tests: run Label to trigger Github Action tests. label Sep 3, 2025

Yuan325 and others added 2 commits September 3, 2025 10:18

Merge branch 'main' into issue-1286-mysql-postgres-tls

da5048b

update tests

8eb58a5

Yuan325 added the tests: run Label to trigger Github Action tests. label Sep 3, 2025

github-actions bot removed the tests: run Label to trigger Github Action tests. label Sep 3, 2025

Merge branch 'main' into issue-1286-mysql-postgres-tls

d87df20

Yuan325 added the tests: run Label to trigger Github Action tests. label Sep 3, 2025

github-actions bot removed the tests: run Label to trigger Github Action tests. label Sep 3, 2025

Yuan325 merged commit 3ae2526 into googleapis:main Sep 3, 2025
12 checks passed

release-please bot mentioned this pull request Sep 3, 2025

chore(main): release 0.14.0 #1261

Merged

BrewTestBot mentioned this pull request Sep 5, 2025

mcp-toolbox 0.14.0 Homebrew/homebrew-core#236305

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(source/mysql): support `queryParams` in MySQL source #1299

feat(source/mysql): support `queryParams` in MySQL source #1299

Uh oh!

govegasbudapest commented Aug 31, 2025 •

edited by Yuan325

Loading

Uh oh!

google-cla bot commented Aug 31, 2025

Uh oh!

Yuan325 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yuan325 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yuan325 left a comment

Uh oh!

Yuan325 commented Sep 3, 2025

Uh oh!

Yuan325 commented Sep 3, 2025

Uh oh!

Yuan325 commented Sep 3, 2025

Uh oh!

Yuan325 commented Sep 3, 2025

Uh oh!

Uh oh!

Uh oh!

feat(source/mysql): support queryParams in MySQL source #1299

feat(source/mysql): support queryParams in MySQL source #1299

Uh oh!

Conversation

govegasbudapest commented Aug 31, 2025 • edited by Yuan325 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Changes

Sources

Uh oh!

google-cla bot commented Aug 31, 2025

Uh oh!

Yuan325 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yuan325 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Yuan325 left a comment

Choose a reason for hiding this comment

Uh oh!

Yuan325 commented Sep 3, 2025

Uh oh!

Yuan325 commented Sep 3, 2025

Uh oh!

Yuan325 commented Sep 3, 2025

Uh oh!

Yuan325 commented Sep 3, 2025

Uh oh!

Uh oh!

Uh oh!

feat(source/mysql): support `queryParams` in MySQL source #1299

feat(source/mysql): support `queryParams` in MySQL source #1299

govegasbudapest commented Aug 31, 2025 •

edited by Yuan325

Loading