feat(source/bigquery): Add support for datasets selection #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuan325
requested changes
Sep 3, 2025
internal/tools/bigquery/bigquerylisttableids/bigquerylisttableids.go
Outdated
Show resolved
Hide resolved
Yuan325
reviewed
Sep 3, 2025
internal/tools/bigquery/bigquerylisttableids/bigquerylisttableids.go
Outdated
Show resolved
Hide resolved
Yuan325
approved these changes
Sep 9, 2025
internal/tools/bigquery/bigquerylisttableids/bigquerylisttableids.go
Outdated
Show resolved
Hide resolved
internal/tools/bigquery/bigquerylisttableids/bigquerylisttableids.go
Outdated
Show resolved
Hide resolved
internal/tools/bigquery/bigquerylisttableids/bigquerylisttableids.go
Outdated
Show resolved
Hide resolved
internal/tools/bigquery/bigquerylisttableids/bigquerylisttableids.go
Outdated
Show resolved
Hide resolved
internal/tools/bigquery/bigquerylisttableids/bigquerylisttableids.go
Outdated
Show resolved
Hide resolved
internal/tools/bigquery/bigquerylisttableids/bigquerylisttableids.go
Outdated
Show resolved
Hide resolved
…ids.go Co-authored-by: Yuan Teoh <[email protected]>
…ids.go Co-authored-by: Yuan Teoh <[email protected]>
…ids.go Co-authored-by: Yuan Teoh <[email protected]>
…ids.go Co-authored-by: Yuan Teoh <[email protected]>
…ids.go Co-authored-by: Yuan Teoh <[email protected]>
…ids.go Co-authored-by: Yuan Teoh <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Sep 10, 2025
) ## Description --- - bigquery Source: The source configuration now supports a new allowedDatasets field, which defines the list of datasets the tools are allowed to access. - bigquery-list-table-ids: Now verifies that the requested dataset is in the allowed datasets list before listing its tables. An error is returned if access is not permitted. ## PR Checklist --- > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/langchain-google-alloydb-pg-python/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #<issue_number_goes_here> --------- Co-authored-by: Yuan Teoh <[email protected]> aa39724
github-actions bot
pushed a commit
to renovate-bot/googleapis-_-genai-toolbox
that referenced
this pull request
Sep 10, 2025
…ogleapis#1313) ## Description --- - bigquery Source: The source configuration now supports a new allowedDatasets field, which defines the list of datasets the tools are allowed to access. - bigquery-list-table-ids: Now verifies that the requested dataset is in the allowed datasets list before listing its tables. An error is returned if access is not permitted. ## PR Checklist --- > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/langchain-google-alloydb-pg-python/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #<issue_number_goes_here> --------- Co-authored-by: Yuan Teoh <[email protected]> aa39724
github-actions bot
pushed a commit
to Genesis929/genai-toolbox
that referenced
this pull request
Sep 10, 2025
…ogleapis#1313) ## Description --- - bigquery Source: The source configuration now supports a new allowedDatasets field, which defines the list of datasets the tools are allowed to access. - bigquery-list-table-ids: Now verifies that the requested dataset is in the allowed datasets list before listing its tables. An error is returned if access is not permitted. ## PR Checklist --- > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/langchain-google-alloydb-pg-python/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #<issue_number_goes_here> --------- Co-authored-by: Yuan Teoh <[email protected]> aa39724
Genesis929
added a commit
to Genesis929/genai-toolbox
that referenced
this pull request
Sep 10, 2025
…#1313) --- - bigquery Source: The source configuration now supports a new allowedDatasets field, which defines the list of datasets the tools are allowed to access. - bigquery-list-table-ids: Now verifies that the requested dataset is in the allowed datasets list before listing its tables. An error is returned if access is not permitted. --- > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/langchain-google-alloydb-pg-python/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #<issue_number_goes_here> --------- Co-authored-by: Yuan Teoh <[email protected]>
github-actions bot
pushed a commit
to bhardwajRahul/genai-toolbox
that referenced
this pull request
Sep 10, 2025
…ogleapis#1313) ## Description --- - bigquery Source: The source configuration now supports a new allowedDatasets field, which defines the list of datasets the tools are allowed to access. - bigquery-list-table-ids: Now verifies that the requested dataset is in the allowed datasets list before listing its tables. An error is returned if access is not permitted. ## PR Checklist --- > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [ ] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/langchain-google-alloydb-pg-python/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Make sure to add `!` if this involve a breaking change 🛠️ Fixes #<issue_number_goes_here> --------- Co-authored-by: Yuan Teoh <[email protected]> aa39724
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #<issue_number_goes_here>