docs: migrate to toolbox-adk and simplified ToolboxToolset
#2211
Conversation
Summary of ChangesHello @anubhav756, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on modernizing the documentation and sample code by migrating from the deprecated Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates ADK-based examples from the legacy toolbox-core to the new toolbox-adk package and updates the usage to a simpler ToolboxToolset constructor. The changes are generally good and align with the goal of simplifying the API.
However, I've noticed a couple of issues in the code samples that could affect users following the guides. I've left specific comments on these.
- In
colab_quickstart.ipynb, there's an inconsistent import path forToolboxToolset. - In
bigquery/local_quickstart.md, an asynchronous function is called withoutawait, which will cause the sample to fail.
Additionally, the PR description states that 'all' quickstart guides are updated, but it seems the migration is focused only on the ADK examples. Other examples using toolbox-core, toolbox-langchain, etc., are not updated. It would be good to clarify the scope of this PR in the description.
anubhav756
changed the title
toolbox-adk and simplified ToolboxToolset
1 similar comment
anubhav756
force-pushed
the
docs/toolbox-adk-migration
branch
from
29695aa to
35088ac
Compare
Yuan325
added
priority: p2
anubhav756
force-pushed
the
docs/toolbox-adk-migration
branch
from
c854e4f to
b7a3493
Compare
2 similar comments
anubhav756
force-pushed
the
docs/toolbox-adk-migration
branch
from
e614069 to
1d2e21f
Compare
anubhav756
force-pushed
the
docs/toolbox-adk-migration
branch
from
1d2e21f to
6cf6fde
Compare
|
/gcbrun |
anubhav756
force-pushed
the
docs/toolbox-adk-migration
branch
from
6cf6fde to
7172250
Compare
|
/gcbrun |
…tion in BigQuery quickstart.
anubhav756
force-pushed
the
docs/toolbox-adk-migration
branch
from
33b3727 to
4332ef8
Compare
4 participants
Updates all quickstart guides and samples to use the new
toolbox-adkpackage instead of the legacytoolbox-core. Also updatesToolboxToolsetusage to rely on the simplified constructor (implicit authentication) and ensures correct dependency installation.Note
The integration tests are failing because the
google-adkpackage is not released yet with the newer changes fromtoolbox-adk. This is expected behavior until the package update is released.