-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore(deps): update node #2214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update node #2214
Conversation
|
|
/gcbrun |
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs routine dependency maintenance by updating two core packages: Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates dependencies for the Node.js quickstarts. The update for @llamaindex/google appears to be a non-breaking improvement. However, the update for @google/adk to v0.2.0 introduces a large number of new peer dependencies for OpenTelemetry. This could cause warnings or errors during installation for users following the quickstart, as these dependencies are not included in the package.json. I've added a comment to address this potential issue.
| "dependencies": { | ||
| "@google/adk": "^0.1.3", | ||
| "@google/adk": "^0.2.0", | ||
| "@toolbox-sdk/adk": "^0.1.5" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update of @google/adk to version ^0.2.0 introduces a significant number of new peerDependencies related to OpenTelemetry. While these seem to be for optional tracing and monitoring features not used in this quickstart, their absence in this package.json will likely cause warnings during npm install and could potentially cause issues with different npm versions or configurations.
For a better user experience in a quickstart guide, it would be ideal to avoid these warnings. If these peer dependencies are required for the quickstart to function, they should be added to the dependencies here. If they are truly optional, it might be worth noting this in the quickstart documentation to preempt user confusion, or exploring if the @google/adk library could be adjusted to use optionalDependencies to improve the developer experience.
|
/gcbrun |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
|
/gcbrun |
|
/gcbrun |
This PR contains the following updates:
^0.1.3->^0.2.0^0.3.20->^0.4.0Release Notes
google/adk-js (@google/adk)
v0.2.1Compare Source
Bumping to version 0.2.1
v0.2.0Compare Source
Bump to version 0.2.0
run-llama/LlamaIndexTS (@llamaindex/google)
v0.4.0Minor Changes
020928c: respect Gemini's requests-per-minute rate limit with waitsv0.3.22Patch Changes
06f884a]v0.3.21Compare Source
Patch Changes
c40adaf: Add latest google models to lib5da1cda]Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.