-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(bigquery): make maximum rows returned from queries configurable #2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d03f96e
feat(bigquery): make maximum rows returned from queries configurable
shobsi 1e308b5
keep it backward compatible with 50 rows of result by default
shobsi 9ffa660
rename the config, add tests
shobsi 8d7c10e
Merge remote-tracking branch 'origin/main' into shobsi-config-max-res…
shobsi fdc8ab5
fix lint errors
shobsi 47f5c62
Merge remote-tracking branch 'origin/main' into shobsi-config-max-res…
shobsi af5dd86
Merge remote-tracking branch 'origin/main' into shobsi-config-max-res…
shobsi 73101c1
Merge remote-tracking branch 'origin/main' into shobsi-config-max-res…
shobsi 8db1d54
Merge remote-tracking branch 'origin/main' into shobsi-config-max-res…
shobsi f0bb3e2
Merge remote-tracking branch 'origin/main' into shobsi-config-max-res…
shobsi 943b26e
Merge remote-tracking branch 'origin/main' into shobsi-config-max-res…
shobsi 6d41ae7
Merge remote-tracking branch 'origin/main' into shobsi-config-max-res…
shobsi 676bf31
Merge branch 'main' into shobsi-config-max-results
shobsi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -124,6 +124,7 @@ sources: | |
| # - "my_dataset_1" | ||
| # - "other_project.my_dataset_2" | ||
| # impersonateServiceAccount: "[email protected]" # Optional: Service account to impersonate | ||
| # maxResultRows: 50 # Optional: Limits the number of rows returned by queries. Defaults to 50. | ||
| ``` | ||
|
|
||
| Initialize a BigQuery source that uses the client's access token: | ||
|
|
@@ -140,6 +141,7 @@ sources: | |
| # - "my_dataset_1" | ||
| # - "other_project.my_dataset_2" | ||
| # impersonateServiceAccount: "[email protected]" # Optional: Service account to impersonate | ||
| # maxResultRows: 50 # Optional: Limits the number of rows returned by queries. Defaults to 50. | ||
| ``` | ||
|
|
||
| ## Reference | ||
|
|
@@ -153,3 +155,4 @@ sources: | |
| | allowedDatasets | []string | false | An optional list of dataset IDs that tools using this source are allowed to access. If provided, any tool operation attempting to access a dataset not in this list will be rejected. To enforce this, two types of operations are also disallowed: 1) Dataset-level operations (e.g., `CREATE SCHEMA`), and 2) operations where table access cannot be statically analyzed (e.g., `EXECUTE IMMEDIATE`, `CREATE PROCEDURE`). If a single dataset is provided, it will be treated as the default for prebuilt tools. | | ||
| | useClientOAuth | bool | false | If true, forwards the client's OAuth access token from the "Authorization" header to downstream queries. **Note:** This cannot be used with `writeMode: protected`. | | ||
| | impersonateServiceAccount | string | false | Service account email to impersonate when making BigQuery and Dataplex API calls. The authenticated principal must have the `roles/iam.serviceAccountTokenCreator` role on the target service account. [Learn More](https://cloud.google.com/iam/docs/service-account-impersonation) | | ||
| | maxResultRows | int | false | The maximum number of rows to return from a query. Defaults to 50. | | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.