Skip to content

Conversation

@C-NASIR
Copy link

@C-NASIR C-NASIR commented Jan 7, 2026

Description

Adds Sources and Auth Services inspection to the Toolbox UI, plus supporting API endpoints. Auth services now show the header name and which tools reference them; sources show a redacted config snapshot and a friendly type summary.

The api.go file was getting too long, so I moved the code to specialized files like api_toolsets.go and api_tools.go.

To test, run the automated tests and start the UI.

🛠️ Fixes #1619

@C-NASIR C-NASIR requested a review from a team as a code owner January 7, 2026 06:18
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @C-NASIR, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the application's introspection capabilities by introducing a new UI and corresponding API endpoints for managing and viewing sources and authentication services. These changes provide users with a clearer understanding of how their data backends and authentication mechanisms are configured and integrated, while also improving the maintainability of the API codebase through strategic refactoring.

Highlights

  • New UI for Sources and Auth Services: Introduced new user interface pages for inspecting configured sources and authentication services, enhancing visibility into their setup and usage.
  • New API Endpoints: Added dedicated API endpoints for listing and retrieving details of individual sources and authentication services.
  • API Refactoring: The main api.go file was refactored, moving specific handlers and related logic into new, specialized files like api_authservices.go, api_sources.go, api_tools.go, api_toolsets.go, and api_common.go for better organization.
  • Auth Service Details: The Auth Services UI now displays the expected header name for each service and lists the tools that reference them.
  • Source Configuration Inspection: The Sources UI provides a redacted configuration snapshot and a friendly type summary for each source, ensuring sensitive information is not exposed.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a great new UI feature for inspecting sources and auth services, and the refactoring of api.go into smaller, more focused files is a good step towards better maintainability. However, the review identified a critical regression: the refactoring of toolInvokeHandler accidentally removed the call to tool.EmbedParams, which breaks the parameter embedding functionality. Additionally, there are a few other issues to address: the API incorrectly determines the header name for auth services, there's a performance inefficiency in one of the new handlers, and there's some duplicated code in the new JavaScript files that could be refactored. Please see the detailed comments for suggestions on how to resolve these issues.

@C-NASIR C-NASIR force-pushed the ui_inspect_sources_and_auth branch from 08fdaf3 to 1bc16e7 Compare January 8, 2026 00:07
@C-NASIR
Copy link
Author

C-NASIR commented Jan 8, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new API endpoints and a corresponding UI for inspecting Sources and Auth Services, which is a great addition for usability. The refactoring of api.go into smaller, more specialized files (api_toolsets.go, api_tools.go, etc.) is a significant improvement for code organization and maintainability. The new frontend code in JavaScript is well-structured and includes good practices like error handling and graceful degradation.

I've left a couple of suggestions for improvement. One is a high-severity issue regarding the redaction of sensitive data, which is currently too aggressive and might hide non-sensitive information. The other is a medium-severity suggestion to refactor some duplicated logic in the new auth service handlers to improve maintainability.

Overall, this is a solid contribution that enhances the project's inspectability.

C-NASIR and others added 2 commits January 7, 2026 18:21
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@duwenxin99 duwenxin99 added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p2 Moderately-important priority. Fix may not be included in next release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Toolbox UI: Inspect other resources (sources and auth services)

2 participants