refactor(sources/cloudhealthcare): move source implementation in Invoke() function to Source

[Yuan325]

Move source-related queries from Invoke() function into Source.

This is an effort to generalizing tools to work with any Source that implements a specific interface. This will provide a better segregation of the roles for Tools vs Source.

Tool's role will be limited to the following:

• Resolve any pre-implementation steps or parameters (e.g. template parameters)
• Retrieving Source
• Calling the source's implementation

[gemini-code-assist]

Summary of Changes

Hello @Yuan325, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant refactoring to the Cloud Healthcare integration by centralizing the implementation details of API calls within the Source component. This change aims to create a clearer division of responsibilities, where Tools focus on orchestrating requests and Source handles the direct interaction with the Cloud Healthcare API. This improves modularity, maintainability, and makes the system more adaptable to different Source implementations in the future.

Highlights

• Code Refactoring: Moved all Cloud Healthcare API interaction logic from individual tool Invoke() functions into the Source struct within internal/sources/cloudhealthcare/cloud_healthcare.go. This centralizes API calls and response handling.
• Separation of Concerns: Enhanced the separation of concerns between Tools and Source. Tools are now responsible for resolving parameters and retrieving the Source, then simply calling the appropriate method on the Source to perform the operation. Source now encapsulates the full implementation of the API calls, including service creation, request building, and response parsing.
• New Source Methods: Added numerous new methods to the Source struct in cloud_healthcare.go to handle specific Cloud Healthcare API operations, such as FHIRFetchPage, FHIRPatientEverything, GetDataset, GetDICOMStore, ListDICOMStores, RetrieveRenderedDICOMInstance, and SearchDICOM.
• Simplified Tool Invoke() Functions: The Invoke() functions across all modified Cloud Healthcare tools have been significantly simplified. They now primarily extract parameters and delegate the core logic to the newly introduced methods on the Source object.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively refactors the Cloud Healthcare tools by moving the implementation logic from the tool's Invoke function into the cloudhealthcare.Source. This is a great improvement for separation of concerns and will make it easier to add new sources in the future. The changes are well-structured and align with the goal described in the pull request.

I've found a critical issue in the cloudhealthcaregetfhirstoremetrics tool where it's calling the wrong source method, and a few medium-severity suggestions for improving code style and consistency.