refactor(sources/looker): move source implementation in Invoke() function into Source

[Yuan325]

Move source-related queries from Invoke() function into Source.

This is an effort to generalizing tools to work with any Source that implements a specific interface. This will provide a better segregation of the roles for Tools vs Source.

Tool's role will be limited to the following:

• Resolve any pre-implementation steps or parameters (e.g. template parameters)
• Retrieving Source
• Calling the source's implementation

[gemini-code-assist]

Summary of Changes

Hello @Yuan325, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant refactoring to the Looker integration by centralizing the creation and management of the Looker SDK client within the Source component. This change enhances the architectural clarity by ensuring that the Source is the single point of truth for Looker API access, allowing individual Tools to focus purely on their operational logic without needing to manage SDK instantiation details. The refactor improves modularity, maintainability, and sets the stage for more generalized tool interactions.

Highlights

• Centralized Looker SDK Initialization: The logic for initializing the Looker SDK, including handling client authorization and TLS configuration, has been moved from a common utility function (lookercommon.GetLookerSDK) into the Source implementation (internal/sources/looker/looker.go).
• Improved Separation of Concerns: This refactoring clearly delineates responsibilities: the Source is now solely responsible for providing the Looker SDK instance, while individual Tools focus on their specific Looker API interactions, leading to cleaner and more modular code.
• Streamlined Tool Invoke() Functions: All Looker-related tools now retrieve the Looker SDK directly from their Source interface via a new GetLookerSDK method, simplifying their Invoke() implementations and reducing boilerplate.
• Interface Updates: The compatibleSource interface in various Looker tools has been updated to reflect the new architecture, removing direct access to LookerClient() and LookerApiSettings() in favor of the new GetLookerSDK method.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a good step towards improving the separation of concerns by moving source-specific logic from the tools into the looker.Source. The relocation of GetLookerSDK is well-executed.

However, the refactoring appears to be incomplete and inconsistent, which introduces some issues:

• Critical: For lookerdeleteprojectfile and lookergetprojectfile, the tools have been updated to call methods (DeleteProjectFile, GetProjectFileContent) on the source interface, but these methods are not implemented on looker.Source. This will cause the application to panic at runtime.
• Medium: For lookercreateprojectfile and lookerupdateprojectfile, the logic has not been moved to the source at all, and they still rely on functions in lookercommon. This is inconsistent with the changes for other file operation tools and the overall goal of the PR.

I've left specific comments with suggestions on how to address these points. Completing this refactoring will make the codebase more robust and maintainable.